Skip to content

re-enable JIT for ZTS builds on Apple Silicon#22712

Merged
arnaud-lb merged 10 commits into
php:masterfrom
realFlowControl:florian/apple-silicon-zts-jit
Jul 15, 2026
Merged

re-enable JIT for ZTS builds on Apple Silicon#22712
arnaud-lb merged 10 commits into
php:masterfrom
realFlowControl:florian/apple-silicon-zts-jit

Conversation

@realFlowControl

@realFlowControl realFlowControl commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #13400

For __APPLE__ && __aarch64__ && ZTS, this PR moves the JIT buffer out of the OPcache shared memory and creates a dedicated mapping.

Background

OPcache JIT is currently disabled for ZTS builds on Apple Silicon. The JIT buffer normally lives at the end of OPcache's MAP_SHARED | MAP_ANON allocation. In ZTS, one thread may generate code while another executes existing code, so the buffer must remain executable while it is writable.

Apple Silicon rejects RWX anonymous mappings with EPERM. Apple's supported solution is MAP_JIT with pthread_jit_write_protect_np(), which provides per-thread write protection, but macOS rejects MAP_JIT | MAP_SHARED with EINVAL. The existing combined OPcache/JIT mapping won't work on Apple Silicon.

@realFlowControl
realFlowControl marked this pull request as ready for review July 13, 2026 08:00
@henderkes

henderkes commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

I don't know if this was in response to my mail, but thank you 😄

@realFlowControl

realFlowControl commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

I don't know if this was in response to my mail, but thank you 😄

Actually yes, haha. I knew that this should work, I just was not working on it and then reading your mail reminded me of it 👍

arnaud-lb
arnaud-lb reviewed Jul 13, 2026
View reviewed changes
Comment thread ext/opcache/jit/zend_jit.c
Comment thread ext/opcache/jit/zend_jit.c
Comment thread ext/opcache/ZendAccelerator.c Outdated
arnaud-lb
arnaud-lb reviewed Jul 13, 2026
View reviewed changes
Comment thread ext/opcache/jit/zend_jit.h
arnaud-lb
arnaud-lb approved these changes Jul 15, 2026
View reviewed changes

@arnaud-lb arnaud-lb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise!

Comment thread ext/opcache/jit/zend_jit.c Outdated
@arnaud-lb
arnaud-lb merged commit a6f85c3 into php:master Jul 15, 2026
1 of 2 checks passed
@arnaud-lb

arnaud-lb commented Jul 15, 2026

Copy link
Copy Markdown
Member

Thank you @realFlowControl!

@realFlowControl
realFlowControl deleted the florian/apple-silicon-zts-jit branch July 15, 2026 14:00
pull Bot pushed a commit to dolfly/php-src that referenced this pull request Jul 16, 2026
@arnaud-lb @realFlowControl
CI: Enable JIT testing on Apple Silicon ZTS 8.6+
fa47ae1 
Related: phpGH-22712

Co-authored-by: Florian Engelhardt <florian.engelhardt@datadoghq.com>
@iluuu1994

iluuu1994 commented Jul 21, 2026

Copy link
Copy Markdown
Member

This change is problematic for CI. I.e. it makes all the tests with an explicit opcache.jit= directive fail. See https://github.com/php/php-src/actions/runs/29793770728/job/88520997977. I'd like to avoid manually implementing SKIPIF for all of these, do you have another idea?

Normally opcache would just log something with ACCEL_LOG_WARNING and ignore the directive, instead of a fatal error. Is that an option?

@realFlowControl

realFlowControl commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

This change is problematic for CI. I.e. it makes all the tests with an explicit opcache.jit= directive fail. See https://github.com/php/php-src/actions/runs/29793770728/job/88520997977. I'd like to avoid manually implementing SKIPIF for all of these, do you have another idea?

Normally opcache would just log something with ACCEL_LOG_WARNING and ignore the directive, instead of a fatal error. Is that an option?

Ah I see. Yeah I think that should work, I have a look and keep you posted.

@realFlowControl realFlowControl mentioned this pull request Jul 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi left review comments
@arnaud-lb arnaud-lb arnaud-lb approved these changes
@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner
@TimWolla TimWolla Awaiting requested review from TimWolla

Assignees

No one assigned

Labels

Category: Build System Category: CI Extension: opcache

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mprotect() failed [13] Permission denied followed by a SIBGUS on MacOS with Apple Silicon and PHP ZTS

5 participants

@realFlowControl @henderkes @arnaud-lb @iluuu1994 @bwoebi